Variable Clean Up

[MSevey]

Overview

For v2 we should clean up a number of outdated or duplicate variables.

.env Variables to Consider

1. portal_domain server_domain portal_custom_domain ansible_host there is some overlap here
2. portal_modules these should only need to be defined in hosts.ini
3. deny_public_access this should be moved to hosts.ini not .env file
4. Airtable fields - we should remove these
5. ACCOUNTS_TEST_USER_EMAIL how are the email and password being used? Are they needed? Can we just define on the fly to create an API key? What happens if they change? Anything?
6. BLOCKER_NGINX_CACHE_PURGE_LOST and LIST remove this outdated variables for v2
7. ABUSE_PORTAL_URL is this not just PORTAL_DOMAIN??
8. ABUSE_SPONSOR is hardcorded, not configurable, should this just be in the abuse repo? or the docker file?

Ansible Variables to Consider

1. docker_commands this should be removed in favor of the generalized shell_commands
2. we should remove the batch_number and batch_size code as we never used it and it is better practice for this to be defined in hosts.ini. Plus with the added complexity of mongo voting members we should just manually define batches

[MSevey]

Should be able to remove test emails SkynetLabs/webportal-health-check#26