Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-lint follow ups #273

Open
6 tasks
MSevey opened this issue Mar 25, 2022 · 0 comments
Open
6 tasks

ansible-lint follow ups #273

MSevey opened this issue Mar 25, 2022 · 0 comments

Comments

@MSevey
Copy link
Contributor

MSevey commented Mar 25, 2022

Describe the bug

The following rules need to be enabled which will require some work and testing to make sure that no bugs are introduced.

  • no-changed-when
  • deprecated-local-action
  • risky-shell-pipe
  • risky-file-permissions
  • command-instead-of-module
  • command-instead-of-shell

Screenshots

# This makes linter to fully ignore rules/tags listed below
skip_list:
  - no-changed-when # TODO: enable https://ansible-lint.readthedocs.io/en/latest/default_rules/#no-changed-when
  - deprecated-local-action # TODO: enable https://ansible-lint.readthedocs.io/en/latest/default_rules/#deprecated-local-action
  - risky-shell-pipe # TODO: enable, need to add pipe fail option https://ansible-lint.readthedocs.io/en/latest/default_rules/#risky-shell-pipe
  - risky-file-permissions # TODO: enable, need to work through errors and set all unset file permissions
  - command-instead-of-module # TODO: enable, looks like there are some places to use this module https://docs.ansible.com/ansible/latest/collections/ansible/builtin/git_module.html
  - command-instead-of-shell # TODO: enable, https://ansible-lint.readthedocs.io/en/latest/default_rules/#command-instead-of-shell

Additional context

@MSevey MSevey mentioned this issue Mar 25, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant