Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/angular-xmcloud][templates/node-xmcloud-proxy] Angular and XM Cloud Proxy Readme updates #1989

Merged
merged 16 commits into from
Dec 6, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Dec 2, 2024

Description / Motivation

This PR includes Angular for XM Cloud and XM Cloud Node Proxy Readme updates, according to lates feedback from PSS.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Chore
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team December 2, 2024 13:28
Copy link

@mattcantcode mattcantcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments relate to Angular. I added some to the Node proxy readme too, but these are mostly addressed in this Word doc: https://sitecore1-my.sharepoint.com/:w:/g/personal/matp_sitecore_net/EYtEb9QYkGFLtNAW5AcyTU8BVp8ciAuaKI4g9Qxz4eY3Tg?e=s0Koma

@@ -1,60 +1,89 @@
# Angular for XMCloud

> Sitecore JSS Angular App for XM Cloud. For the current release this feature is experimental.
> Sitecore JSS Angular App for XM Cloud. For the current release this feature is in public beta.
> If you encounter any issues or bugs, please submit a new issue in the [Jss GitHub Repo](https://github.com/Sitecore/jss)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSS

Copy link
Collaborator

@anasplat anasplat Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular for XMCloud>Angular for XM Cloud

@@ -1,60 +1,89 @@
# Angular for XMCloud

> Sitecore JSS Angular App for XM Cloud. For the current release this feature is experimental.
> Sitecore JSS Angular App for XM Cloud. For the current release this feature is in public beta.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For the current release this feature is in public beta" > "This feature is currently in public beta."

This Single Page Application (SPA) built with Angular is designed to be fully compatible with XM Cloud, incorporating several key add-ons and features to streamline the development process and enable seamless integration.

The Angular XM Cloud integration consists of two parts:
- `XM Cloud Angular`: simplifies connecting the application to XM Cloud and configuring the integration of multiple composable Sitecore products, provides out of the box helper components.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"provides out of the box helper components." > "and provides out-of-the-box helper components."


The Angular XM Cloud integration consists of two parts:
- `XM Cloud Angular`: simplifies connecting the application to XM Cloud and configuring the integration of multiple composable Sitecore products, provides out of the box helper components.
- `XM Cloud Proxy`: Adds integration with XM Cloud for the JSS SPA applications and enables editing, personalization and A/B component testing support, see [XM Cloud Proxy](../node-xmcloud-proxy/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

", see XM Cloud Proxy" > ". See XM Cloud Proxy for more information."

- `XM Cloud Angular`: simplifies connecting the application to XM Cloud and configuring the integration of multiple composable Sitecore products, provides out of the box helper components.
- `XM Cloud Proxy`: Adds integration with XM Cloud for the JSS SPA applications and enables editing, personalization and A/B component testing support, see [XM Cloud Proxy](../node-xmcloud-proxy/)

The supported key features are as follows:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The following key features are supported:"


This proxy will serve as the backbone for supporting various SPA frameworks by handling server-side rendering (SSR), data queries, and middleware functionalities.
This Node.js-based proxy app is the backbone for enabling seamless integration between XM Cloud and various SPA frameworks like React, Angular, or Vue laying the groundwork for future JSS starter kits built for other front-end JavaScript frameworks. It acts as a middleware layer to handle critical functionalities such as server-side rendering (SSR), enabling editing and personalization, A/B component testing, and integrating Sitecore Forms. By serving as the rendering host, it ensures a smooth connection between Sitecore XM Cloud services and your front-end applications, making it easier to build dynamic, personalized, and localized experiences for users.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A/B/n"


## Features Supported

- `Context ID`: The Context ID environment variable simplifies setting up and configuring XM Cloud solutions. It's a unified identifier that maps to all your configured resources, such as content, sites, files, forms, and integration settings.

- `XM Cloud Pages editing integration`: full integration with Pages - the dynamic visual page editor of XM Cloud.

- `XM Cloud proxy personalization` with embedded personalization and A/B Component Test support.
- `XM Cloud proxy personalization` with embedded personalization and Component A/B Testing support.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"component A/B/n testing"

> The following features and integrations are not supported by Node XM Cloud Proxy:
> - Multisite
> - XM CLoud Components application
> - BYOC components

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As elsewhere, please confirm with Anastasia whether we need to say BYOC here as well as the components app.

The config.ts file in this proxy app handles essential configurations for server-side rendering, data queries, and middleware functionalities. Here are the main configurations defined:
> The following features and integrations are not supported by Node XM Cloud Proxy:
> - Multisite
> - XM CLoud Components application

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The XM Cloud Components application"

@@ -49,21 +58,25 @@ This configuration is designed to be flexible and secure, with dynamic settings

### Environment Variables

The following environment variables can be set to configure the Proxy sample instead of modifying `config.js`. You can use the `.env` file located in the root of the app or set these directly in the environment (for example, in containers).
The following environment variables can be set to configure the Node XM Cloud Proxy app instead of modifying `config.js`. You can use the `.env` file located in the root of the app or set these directly in the environment (for example, in containers).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"can be used to configure"

@yavorsk yavorsk merged commit 66dbe29 into dev Dec 6, 2024
1 check was pending
@yavorsk yavorsk deleted the feature/JSS-4644 branch December 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants