Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Step Re-Design: Implement save button instead of onChange #363

Open
2 tasks
itsciccio opened this issue Oct 13, 2022 · 1 comment
Open
2 tasks

Alert Step Re-Design: Implement save button instead of onChange #363

itsciccio opened this issue Oct 13, 2022 · 1 comment

Comments

@itsciccio
Copy link
Contributor

itsciccio commented Oct 13, 2022

Description

The delay on every update in the alerts page is too quick, causing many API calls.

Update: It has been decided to overhaul this page by implementing a Save button instead of the current onChange logic as it is the most simplistic way forward.

Requirements

- [ ] Extend debounce time to 2seconds.
- [ ] Test by altering the configurations and check that the time between API calls is reasonable.

  • Re-design the component so to update the entire configuration with a save button
  • Test accordingly to make sure the config is updated in Mongo.

Acceptance criteria

Scenario: I wish to edit an alerts configuration for any sub-chain
Given: A valid config either fresh or edited
Then: A reasonable time between API calls

Scenario: Updating PANIC Configs
Given: Some changes made in the page
When: Save button pressed
Then: Alert config saved in DB.

@itsciccio itsciccio added this to the UI iteration 2 milestone Oct 13, 2022
@itsciccio itsciccio added the UAT Findings from the UAT label Oct 13, 2022
@itsciccio
Copy link
Contributor Author

The component is designed to update a single change at a time, as by extending the debounce will solve the original issue yet cause other issues. This page is to be converted in a way to have a Save button (similar to the sub-chain step). As for the time being, this issue will be skipped as PANIC still functions well without this change, and as a ticket it will require an overhaul for the alert setup page.

@itsciccio itsciccio changed the title Amend debounce in Alert Step Alert Step Re-Design: Implement save button instead of onChange Oct 14, 2022
@dillu24 dillu24 removed this from the UI iteration 2 milestone Oct 17, 2022
@itsciccio itsciccio removed the UAT Findings from the UAT label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants