Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media player for virtual tours on property detail page #186

Open
spmiller2 opened this issue Nov 3, 2020 · 1 comment
Open

media player for virtual tours on property detail page #186

spmiller2 opened this issue Nov 3, 2020 · 1 comment
Labels
enhancement This is an enhancement or new feature feedback This issue or PR is based on user feedback help wanted This could use input from others

Comments

@spmiller2
Copy link

A request was made to have a media player plugin on the property detail page which would play any virtual tours that are available in the listing data.

Something like what realtor.ca does.

image

Place a media player toward the top of listing details, below the address and property photos.

Currently, we do convey the tour URL, but its just a data point in the body, not in a media player.

If we added this feature, it would be prudent to include an on/off flag in settings (with the default to off) for users who may not want such a feature.

Marked "help wanted" in case anyone has done this already and has any suggestions on it.

@spmiller2 spmiller2 added enhancement This is an enhancement or new feature help wanted This could use input from others feedback This issue or PR is based on user feedback labels Nov 3, 2020
@CodyReichert
Copy link
Member

I agree, this would be a great feature. Some initial thoughts:

To show a media player on the same page, we would need to know that we have a valid URL to a video file. I've seen URL's that point to another web page which has the video embedded. Is there a way we can validate the URL?

We could definitely start by supporting this for youtube URLs (as is the case in the picture). These we can work on making our URL handling more sophisticated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement or new feature feedback This issue or PR is based on user feedback help wanted This could use input from others
Projects
None yet
Development

No branches or pull requests

2 participants