-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: replacable editors #62
Comments
This is an overview of the current set of configurations: componentDataApi.html
componentPageTemplate.html
componentSorters.html
componentQUnitTests.html
componentPageFrame.html
componentRawApi.html
componentTransformers.html
componentRoutes.html
componentHeadHtml.html
componentCommands.html
componentFootHtml.html
componentDataSources.html
componentPageCss.html
componentBodyHtml.html
component-actions/componentTemplates/componentActions.html
componentComponentTemplate.html:
componentComponentTemplate.html
componentComponentCss.html
|
if we had the option to pass parameters to a simply-render component, that gets picked up in the rendered result, we could create a single editor component, and add specific instances of it in a specific other component type. e.g.
which would generate
|
What if simply-render gets a transformer-like thing:
and a bit of code to manage it all:
I think something like this would allow a lot of customization for what we can do with simply-render step, while reusing concepts within the stack that are already familiar? |
The current editors are directly added in the HTML as:
With a recent discussion about upgrading to codemirror 6 or the monaco editor, what fell into place is the idea that it would be good to have a way to upgrade this bit in one go somehow. The big question is 'how'.
We currently have 29 instances of the editor, spread out over the different places they are used. Raw API, Unit tests, Page templates each have their own textarea with a slightly different configuration each time.
Ideally, the solution would allow us to replace these editors in one go. This could be done by creating a 'component-editors' component, with pre-configured editors for each type that we need.
The downside is that this requires the creation of a component that is aware of each of the other components. If we ever decide to add another type of component that warrants a different type of editor configuration, adding this would also require the addition of another editor in component-editors. This means the code for this new thing would still be fragmented over the codebase, which is not in line with the thinking of how things should be structured in simplyCode.
So the question is this: can we create something that will allow us to:
The text was updated successfully, but these errors were encountered: