Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace VM2 #6

Open
poef opened this issue Aug 8, 2024 · 0 comments
Open

replace VM2 #6

poef opened this issue Aug 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@poef
Copy link
Member

poef commented Aug 8, 2024

VM2 is known insecure, I should probably switch to v8-isolate or QuickJS.

However, do we even really need it? Since all queries are run inside a worker thread, can we isolate that well enough?

TODO: figure out what globals are available in a worker thread in node, see if we can limit access to them, or remove them before running untrusted code.

See also: https://stackoverflow.com/questions/5408406/web-workers-without-a-separate-javascript-file?rq=1
@poef poef added the enhancement New feature or request label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@poef