Price Discrepancies between DEX UI and SIfchainJS

[lufa23]

Current behavior
Price Discrepancies between SifchainJS and DEX UI. Price discrepancies are higher if the price impact is higher (for example when swapping in low-depth pools).
Expected behavior

• Use the DEX UI to perform a swap and get the same exact price than with using the SIfchainJS

Steps to reproduce

• Use the DEX UI and get to the swap screen, specifying the amount of token A that you want to swap
• Check how many token B amount will be received for that token A amount
• Note down the expected prices (and the minimum received field)
• Try the above with different pools
• Compare the results with the results from using the SIfchainJS

What tokens are you interacting with when this issue occurs?
All tokens. Price differences are higher when Price Impact is higher

VIDEO

5432345432_gd5NGSO4.mov

[lufa23]

another user witnessed a similar issue:

Testing the SifchainJS docs, and trying to run the code for the function simulateSwap, the output received from signingClient.simulateSwap() is:
minimumReceiving for 1 rowan -> usdc is 0 as per sample code by querying console.log("Min Receiving: ", swap.minimumReceiving.toString());

From the UI, the user i expecting at least 0.003855 USDC -> 3855 (6 decimal places)

[lufa23]

hey guys we got another feedback regarding this, as it is mentioned that last version introduced results that are very off.. can you check on this?

[lufa23]

the second user is providing more information:
Same time, in the case of version 0833b21 gives a result(discrepant from the UI), in the case of the latest version (1.0.0) the result is 0

Anyways the version 0833b21 gives a result different from the UI.

[lufa23]

As we don't provide backwards compatibility, we will focus on understanding why on version 1.0.0 getting the simulateSwap gives result that is 0 (or a discrepant number, depending on the pools)