Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Update to ol 7 and ol-ext 4 #96

Merged
merged 6 commits into from
Sep 19, 2022
Merged

WIP Update to ol 7 and ol-ext 4 #96

merged 6 commits into from
Sep 19, 2022

Conversation

Siedlerchr
Copy link
Owner

@Siedlerchr Siedlerchr commented Sep 17, 2022

I could not get the examples to work yet:

Uncaught TypeError: ol.ext is undefined
    js Base.js:10
    Webpack 11
[Base.js:10](webpack://siedlerchr/types-ol-ext/node_modules/ol-ext/util/input/Base.js)
    js Base.js:10
    Webpack 11

@sanak Any idea if we need to change sth here or if ol-ext needs to change it?

TODO: Get examples up and running
@sanak
Copy link
Collaborator

sanak commented Sep 18, 2022

@sanak Any idea if we need to change sth here or if ol-ext needs to change it?

Okay. I will check it a bit by tomorrow.

@sanak
Copy link
Collaborator

sanak commented Sep 18, 2022

@Siedlerchr
I created the following PR to ol-ext side.
Viglino/ol-ext#856

I will check this PR examples further after tonight.

@sanak
Copy link
Collaborator

sanak commented Sep 18, 2022

Here is quick check result after applying https://github.com/Viglino/ol-ext/pull/856/files locally (edit ./node_modules/ol-ext/util/**.js directly) then build examples.
I guess that significant error is only style/map.style.font.ts (except animation/map.featureanimation.ts), but I will try to solve those.

  • animation
  • bar
    • map.control.bar.ts
    • map.control.button.ts
    • map.control.editbar.ts
  • canvas
    • map.control.gridreference.ts
  • control
    • map.control.geobookmark.ts
      Uncaught ReferenceError: bm is not defined
          at HTMLInputElement.onchange (map.control.geobookmark.html:53:113)
      
      => Fixed with 667a1cd
    • map.switcher.popup.ts
  • filter
    • map.filter.crop.ts
  • geom
    • map.geom.cspline.ts
  • interaction
    • map.interaction.clip.ts
    • map.interaction.drawregular.ts
  • map
    • map.layer.3d.2.ts
  • misc
    • map.animatedcanvas.ts
    • map.compare.ts
    • map.input.ts
      Uncaught ReferenceError: dialog is not defined
          at HTMLButtonElement.onclick (map.input.html:109:37)
      
      => Fixed with e3a9565
  • popup
    • map.fixedpopup.ts
    • map.popup.feature.ts
    • map.popup.ts
  • search
    • map.control.searchnominatim.ts
  • storymap
    • map.control.imageline.ts
  • style
    • map.style.font.ts
      Uncaught TypeError: Cannot read properties of undefined (reading 'glyphs')
          at ./examples/style/map.style.font.ts (map.style.font.ts:49:41)
          at __webpack_require__ (bootstrap:19:1)
          at startup:4:1
          at startup:4:1
      
      => Fixed with ee69094
    • map.style.pattern.ts
      Uncaught ReferenceError: refresh is not defined
          at HTMLSelectElement.onchange (map.style.pattern.html:121:49)
      
      => Fixed with 75a4998

@sanak
Copy link
Collaborator

sanak commented Sep 19, 2022

@Siedlerchr
I fixed some type defs/examples, so please check my additional commits, when you have a time.
Thanks,

@Siedlerchr
Copy link
Owner Author

Thanks looks good so far!

@Siedlerchr Siedlerchr merged commit ca6b25d into master Sep 19, 2022
@Siedlerchr Siedlerchr deleted the ol7 branch September 19, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants