Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different way to response error #4

Open
oiami opened this issue Feb 22, 2016 · 3 comments
Open

Different way to response error #4

oiami opened this issue Feb 22, 2016 · 3 comments

Comments

@oiami
Copy link
Contributor

oiami commented Feb 22, 2016

I got a patch from user suggesting to change data structure of error response here the detail.

patch_different_return_type

@h3ct0r
Copy link

h3ct0r commented Aug 6, 2016

Hi, this is very important, I had some problems with this bug, if the HTTP tiny module does not reach google for any reason it doesn't return a HASH and your program may crash.

Why this haven't been addressed? If needed I can create a pull request with the changes.

@kohts
Copy link

kohts commented Mar 4, 2018

Another example of possible failure from HTTP::Tiny which is masked by this module:
Net::SSLeay 1.49 must be installed for https support.

The patch quoted above would fix the issue. @oiami, I guess creating pull request
would simplify adding the fix into the trunk for the author. Please let me know
if you'd like to create pull request by yourself or you want me to do it.

@JavierElices
Copy link

JavierElices commented Mar 16, 2018

Hi, I have run into this today. I had neither of IO::Socket::SSL or NET::SSLeay and the module silently returns nothing from the verify method. Either a croak as suggested or at least a return { success => 0, error_codes => undef }; at the end of the verify method to warn that something is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants