Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server responds with "internal error" when ephemeral account wasn't found #139

Closed
ChrisSchinnerl opened this issue Dec 17, 2024 · 1 comment · Fixed by #140
Closed

Server responds with "internal error" when ephemeral account wasn't found #139

ChrisSchinnerl opened this issue Dec 17, 2024 · 1 comment · Fixed by #140
Assignees

Comments

@ChrisSchinnerl
Copy link
Member

Right now all RHP4 routes which call DebitAccount will return an internal error when they fail for whatever reason. Since renters rely on proper errors we should change that behavior to be similar to CreditAccountWithContract.

When an account isn't found, or when the balance is insufficient, we should return an exported ErrInsufficientBalance. The renter then knows to fund the account to fix the error.

@ChrisSchinnerl
Copy link
Member Author

@n8maninger might need to extend the integration tests in hostd as well.

@github-project-automation github-project-automation bot moved this from Todo to Done in Sia Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants