-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Create ScanQR screen for AR viewer #109
Comments
Hi @ShwetKhatri2001 I'd like to work on this under SWOC24 |
I have already assigned you an issue. You may proceed with that first and then come here again. |
I would like to work on this under swoc |
Okay, go ahead. |
Sorry I tried this but I was not able to solve this , so I am unassigning myself. |
I'd like to take this one up @ShwetKhatri2001 |
Sure, Please complete the assigned issue first. After that, I can assign you this. |
Description
If the AR is not supported on the current device then we are showing a QR code currently to scan it and view AR on another device.
To get rid of the extra space being used for the QR code,
Create a button on the desktop 3D viewer similar to the "View in your space" button being shown on mobile currently. Keep it at the center bottom having the same styles.
But on desktop, the button will function differently, it will basically open a new screen on the viewer as an overlay having that QR code, URL, and the details about on which devices AR is supported. It should be responsive for any width/height of the viewer container since we will have different width and height at different places.
Once you complete the points given above, remove the old implementation to scan QR.
Note : There is a similar button already for supported devices.
So, this new button shouldn't be coming up on supported devices ( mobile ), since it's only for the devices where AR is not supported.
Screenshots
For UI have a look at that
View in your space
button.For functionality take a look at how it works on Sketchfab Bag example present in the
Works on iOS and Android
section.The button you create will function like the
[ AR ]
button present there but the button styles will be different as I discussed above. You may keep the structure of the elements on the ScanQR overlay similar as shown there. There should be a close button as shown there.( Try not to have a scrollbar like they are having ).
Checklist
The text was updated successfully, but these errors were encountered: