Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create ScanQR screen for AR viewer #109

Open
2 of 4 tasks
ShwetKhatri2001 opened this issue Jul 6, 2023 · 7 comments
Open
2 of 4 tasks

[Feature] Create ScanQR screen for AR viewer #109

ShwetKhatri2001 opened this issue Jul 6, 2023 · 7 comments
Labels
feature Adding new feature Medium medium level issue SWOC S4 Assigned to SWOC S4 contributor up for grabs open to contributors

Comments

@ShwetKhatri2001
Copy link
Owner

ShwetKhatri2001 commented Jul 6, 2023

Description

If the AR is not supported on the current device then we are showing a QR code currently to scan it and view AR on another device.
To get rid of the extra space being used for the QR code,

  • Create a button on the desktop 3D viewer similar to the "View in your space" button being shown on mobile currently. Keep it at the center bottom having the same styles.

  • But on desktop, the button will function differently, it will basically open a new screen on the viewer as an overlay having that QR code, URL, and the details about on which devices AR is supported. It should be responsive for any width/height of the viewer container since we will have different width and height at different places.

  • Once you complete the points given above, remove the old implementation to scan QR.

image

Note : There is a similar button already for supported devices.
So, this new button shouldn't be coming up on supported devices ( mobile ), since it's only for the devices where AR is not supported.

Screenshots

For UI have a look at that View in your space button.



For functionality take a look at how it works on Sketchfab Bag example present in the Works on iOS and Android section.
The button you create will function like the [ AR ] button present there but the button styles will be different as I discussed above. You may keep the structure of the elements on the ScanQR overlay similar as shown there. There should be a close button as shown there.
( Try not to have a scrollbar like they are having ).

Checklist

  • I have checked the existing issues
  • I have read the [Contributing Guidelines]
  • I am willing to work on this issue (optional)
  • I am a GSSoC'23 contributor
@ShwetKhatri2001 ShwetKhatri2001 added gssoc23 Assigned to GSSoC23 contributor level2 feature Adding new feature up for grabs open to contributors labels Jul 6, 2023
@ShwetKhatri2001 ShwetKhatri2001 added Medium medium level issue and removed gssoc23 Assigned to GSSoC23 contributor level2 labels Dec 10, 2023
@ShatilKhan
Copy link

ShatilKhan commented Dec 28, 2023

Hi @ShwetKhatri2001 I'd like to work on this under SWOC24

@ShwetKhatri2001
Copy link
Owner Author

I have already assigned you an issue. You may proceed with that first and then come here again.

@ShwetKhatri2001 ShwetKhatri2001 added the SWOC S4 Assigned to SWOC S4 contributor label Jan 1, 2024
@ayann07
Copy link
Contributor

ayann07 commented Jan 17, 2024

I would like to work on this under swoc

@ShwetKhatri2001
Copy link
Owner Author

Okay, go ahead.

@ShwetKhatri2001 ShwetKhatri2001 removed the up for grabs open to contributors label Jan 17, 2024
@ayann07
Copy link
Contributor

ayann07 commented Jan 18, 2024

Sorry I tried this but I was not able to solve this , so I am unassigning myself.

@ayann07 ayann07 removed their assignment Jan 18, 2024
@ShatilKhan
Copy link

I'd like to take this one up @ShwetKhatri2001
I've done some similar QR Scanner before, can I take this after I finish up my previous issue?

@ShwetKhatri2001 ShwetKhatri2001 added the up for grabs open to contributors label Jan 21, 2024
@ShwetKhatri2001
Copy link
Owner Author

Sure, Please complete the assigned issue first. After that, I can assign you this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new feature Medium medium level issue SWOC S4 Assigned to SWOC S4 contributor up for grabs open to contributors
Projects
None yet
Development

No branches or pull requests

3 participants