Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TranslationKeyExists check not detecting translations in section schema #721

Open
david-w-shopify opened this issue Jan 20, 2025 · 2 comments
Labels
Bug Something isn't working SEV-2 High Severity

Comments

@david-w-shopify
Copy link

david-w-shopify commented Jan 20, 2025

Describe the bug
When using the locales object in a section schema, Theme Check incorrectly flags them as missing

Image

Source

// section/test-section.liquid

<p>{{ 'sections.test-section.title' | t }}</p>
<p>{{ 'sections.test-section.description.desktop' | t }}</p>
<p>{{ 'sections.test-section.description.mobile' | t }}</p>

{% schema %}
{
  "name": "Section",
  "locales": {
    "en": {
      "title": "Title",
      "description": {
        "desktop": "Lorem ipsum dolor sit amet consectetur, adipisicing elit.",
        "mobile": "Lorem ipsum dolor sit amet"
      }
    }
  }
}
{% endschema %}

Expected behaviour
No errors

Actual behaviour
The first three lines all have TranslationKeyExists errors

Debugging information

  • OS: Mac
  • OS Version: Sequoia 15.2
  • Theme Check Version: 3.73.2
@aswamy aswamy added Bug Something isn't working SEV-2 High Severity labels Jan 21, 2025
@aswamy
Copy link
Contributor

aswamy commented Jan 21, 2025

Good catch. Seems like the auto-completion also ignores in-file translations.

Image

@aswamy
Copy link
Contributor

aswamy commented Jan 21, 2025

Ah looks like you already reported that too ❤
#720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SEV-2 High Severity
Projects
None yet
Development

No branches or pull requests

2 participants