Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme profile cla workaround #5175

Closed
wants to merge 32 commits into from
Closed

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Jan 9, 2025

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@karreiro
Copy link
Contributor Author

karreiro commented Jan 9, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.14% (+0.01% 🔼)
8867/11800
🟡 Branches
70.33% (+0.02% 🔼)
4311/6130
🟡 Functions 75.06% 2318/3088
🟡 Lines
75.71% (+0.02% 🔼)
8383/11072
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%

Test suite run success

2000 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from 986d2ba

@karreiro
Copy link
Contributor Author

karreiro commented Jan 9, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro karreiro closed this Jan 9, 2025
@karreiro karreiro force-pushed the theme-profile-cla-workaround branch from 1a56b88 to ed55fc7 Compare January 9, 2025 13:22
@karreiro karreiro reopened this Jan 9, 2025
@karreiro
Copy link
Contributor Author

karreiro commented Jan 9, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro karreiro force-pushed the theme-profile-cla-workaround branch from 10e0fbe to d33d13e Compare January 9, 2025 14:30
@karreiro
Copy link
Contributor Author

karreiro commented Jan 9, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro
Copy link
Contributor Author

karreiro commented Jan 9, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro karreiro force-pushed the theme-profile-cla-workaround branch from 986d2ba to 9b8226e Compare January 10, 2025 14:02
@karreiro
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro karreiro force-pushed the theme-profile-cla-workaround branch from 9b8226e to 986d2ba Compare January 10, 2025 15:33
@karreiro karreiro closed this Jan 10, 2025
Copy link
Contributor

Unused dependencies (1)

Filename dependencies
packages/cli/package.json speedscope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants