Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cli hydrogen on Stable/3.72 #5080

Closed
wants to merge 1 commit into from

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Hydrogen cli has a version bump

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@wizardlyhel wizardlyhel requested review from a team as code owners December 11, 2024 19:24
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/git.d.ts
@@ -97,13 +97,6 @@ export declare class OutsideGitDirectoryError extends AbortError {
  * @param directory - The directory to check.
  */
 export declare function ensureInsideGitDirectory(directory?: string): Promise<void>;
-/**
- * Returns true if the given directory is inside a .git directory tree.
- *
- * @param directory - The directory to check.
- * @returns True if the directory is inside a .git directory tree.
- */
-export declare function insideGitDirectory(directory?: string): Promise<boolean>;
 export declare class GitDirectoryNotCleanError extends AbortError {
 }
 /**

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.28% 8769/11649
🟡 Branches 70.54% 4274/6059
🟡 Functions 75.03% 2293/3056
🟡 Lines 75.83% 8291/10934

Test suite run success

1973 tests passing in 895 suites.

Report generated by 🧪jest coverage report action from 0f64af9

@wizardlyhel
Copy link
Contributor Author

Don't need anymore - 3.73.0 is released

@wizardlyhel wizardlyhel closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants