Filter orgs to only those with develop_apps permission #5036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Depends on https://github.com/Shopify/business-platform/pull/23112
Needed for https://github.com/Shopify/develop-app-inner-loop/issues/2343
Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2283
Dependency of #5004
To prevent users from seeing a long list of orgs they can't actually develop with.
WHAT is this pull request doing?
Filters organization list (
Which organization is this work for?
) to only show organizations where the user has thedevelop_apps
permissions.How to test your changes?
app config link
with a user that has access to BP orgs withdevelop_apps
(e.g. Dev User). It should work as usual, you will be prompted to select an org.app config link
the CLI with a user that has access to BP orgs without thedevelop_apps
permission (e.g. Alice). You should get an error because no orgs are available.main
, you will be prompted to select one of these orgs, but you'll hit downstream problems because you lack the necessary permissions to develop apps using those orgs.Tophatting won't work properly until some caching behavior is cleaned up here.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist