-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add silence flag to the theme dev commands #4919
base: main
Are you sure you want to change the base?
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success1968 tests passing in 892 suites. Report generated by 🧪jest coverage report action from f338316 |
112d876
to
8cbbac5
Compare
To consider: granularity for sync logs ( file upload / download ). Do we need more granularity for how verbose the logs are? |
8cbbac5
to
acc6b57
Compare
This commit adds a `--silence` flag to the `theme dev` command. When this flag is passed, it will disable request logging.
acc6b57
to
f338316
Compare
Perhaps we should go with a flag that we can extend later instead of (complete) --silence? There's also Thoughts? |
@frandiox 100% on the same page that adding something like My 2 🪙 :
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
WHY are these changes introduced?
Closes: #4714
I saw a slack post talking about request logs (Ex:
• 12:57:27 Request » GET 200 /collections/all 51
) are too noisy and they wish they could be disabled.Fixes #0000
WHAT is this pull request doing?
Add a
--silence flag to the theme dev command to disable request logs
Before:
After:
How to test your changes?
Pull down the branch
Build the branch
Run
theme dev --silence
and click around in your theme links like collections, products, etc.You shouldn't see any request logs in the terminal.
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist