Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't connect Github account to Shopify #2006

Closed
2 tasks done
ttiimmaacc opened this issue Jun 20, 2022 · 19 comments
Closed
2 tasks done

[Bug]: Can't connect Github account to Shopify #2006

ttiimmaacc opened this issue Jun 20, 2022 · 19 comments

Comments

@ttiimmaacc
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

What type of project are you working on?

app

Expected behavior

Okay, Shopify support sent me here, although I'm not sure why because I'm not inside the command line.

My issue is connecting my account form the Online store.
I've read through the guides, tried a new development store, a different browser and the issue is that the Shopify app integration is not connecting my Github. It is remaining stuck on a loading page.

Actual behavior

Stuck on loading screen, no Github account, no branch to connect to.

Stack trace

No response

Reproduction steps

1.Online store
2.Add theme
3.Connect to Github

Operating System

MacOs

CLI version (run shopify version if you're not sure)

2.19

Shell

No response

Ruby version (run ruby -v if you're not sure)

No response

What language and version are you using in your application?

No response

@myersa2
Copy link

myersa2 commented Sep 15, 2022

same

@kaydwithers
Copy link

I'm also facing this issue. If I retry, there is a note saying "Cancel Request" for my GitHub organisation.

@andrewskr90
Copy link

Also experiencing this issue

@firmlab
Copy link

firmlab commented Oct 28, 2022

image
same here, get stuck on this screen

@lovetheidea
Copy link

lovetheidea commented Nov 21, 2022

Same here -- on Chrome and on Safari.

Anyone have a solution?

image

@jean-wab
Copy link

Having a similar yet different issue. My account gets connected, but it doesn't recognise any of my repositories. My theme code is just a copy of dawn - the structure is fine, I have no idea why it's not working.
I have tried:

  • Making the target repo public
  • Uninstalling and reinstalling the Shopify app on my Github account
  • Giving Shopify app access to all of my repos
  • Restricting Shopify app access to only the target repo

Issue

image

Repo structure

image

It is starting to become frustratingly common for Shopify to have dev features that are half-baked.

@danspringer
Copy link

Same problem here.
Redirect-Screen gets stuck.
Bildschirmfoto 2023-01-19 um 15 29 32

@tm-dumais
Copy link

Is this going to be fixed any time soon?
Makes the whole dev environment around shopify fairly useless

@securfix
Copy link

securfix commented Feb 8, 2023

Same issue, how muxh time will it take to get any solution for this.

@redamakarem
Copy link

Hello
Same issue here, I connect to my account but no repos show up

@daniel-apoio
Copy link

Same issue on two different accounts and different PC`s

@meladiv76
Copy link

I guess it can be related to 2FA on the account...

@jonathanrpeters
Copy link

I don't have 2FA on my account and having the same issue. One account is connected. Another attempt to connect hangs and never connects, despite GitHub App permissions being granted they never seem to get read.

Do you guys have multiple GitHub accounts connected as well?

@marcoswata
Copy link

@jonathanrpeters I was able to connect one account. When I tried connecting the second account, it was hanging like the others said. I tried the whole thing in Incognito mode and it finally logged into the second account when connecting it, but it doesn't show in the dropdown of Github accounts. Instead, it opens a popup with the Github account settings...

@jonathanrpeters
Copy link

@marcoswata That's exactly the problem I'm having. The connection fails on the initial install -> https://online-store-git.shopifyapps.com/github/setup?installation_id=XXXXXXXX&setup_action=install

Then it keeps trying to connect to an installation that doesn't exist so 404's. GitHub and Shopify are connected but doesn't seem to be registered as such in Shopify.

@jonathanrpeters
Copy link

@marcoswata I was able to get this to work by adding a new user as a Shopify Staff and as a GitHub Owner and then go through the process with that account.

@marcoswata
Copy link

@jonathanrpeters sounds like a great workaround for now, I hope they can fix this soon though. Thanks for that.

@karreiro karreiro transferred this issue from Shopify/shopify-cli May 29, 2023
@isaacroldan
Copy link
Contributor

Closing this issue as it's not related to the shopify CLI. The issue is tracked internally.

@mitesh-avid-brio
Copy link

it's still not resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests