Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak from Redis due to missing key expirations #280

Open
yqiu24 opened this issue Jun 7, 2024 · 1 comment
Open

Memory leak from Redis due to missing key expirations #280

yqiu24 opened this issue Jun 7, 2024 · 1 comment

Comments

@yqiu24
Copy link

yqiu24 commented Jun 7, 2024

Hi, we are using ci-queue for minitest and noticed that the memory usage in our Redis cluster grows slowly over time, despite using the default TTL of 8 hours. It appears that this is because not all keys have a corresponding expire call. For example, the requeues-count key is never expired. Same thing for the running key. Is there any reason that only certain keys are marked as expired?

@casperisfine
Copy link
Contributor

This is because ci-queue has been built around the idea of Redis being configued with maxmmemory-policy = allkeys-lru, as documented here: https://github.com/Shopify/ci-queue?tab=readme-ov-file#redis-requirements.

Later on some support was added to add TTL to keys, but some must have been missed: #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants