Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation recommends using v1.0.0 which doesn't work anymore #851

Open
vincentkoeckerling opened this issue Aug 29, 2023 · 2 comments
Open

Comments

@vincentkoeckerling
Copy link

The documentation gives the following code for including the library:

<script src="http://sdks.shopifycdn.com/buy-button/1.0.0/buybutton.js"></script>

But version 1.0.0 does not work anymore. When you try to create a cart it throws

buybutton.js:15150 TypeError: Cannot read properties of undefined (reading 'checkoutCreate')

Is it possible to update the documentation to make it clearer a newer version is required?

@dannytrann
Copy link

Following - something changed in the code that broke my website. Looking to get an update on this.

@amustill
Copy link

I personally resolved this by using the latest minified version of the SDK:

<script src="https://sdks.shopifycdn.com/buy-button/latest/buy-button-storefront.min.js"></script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants