-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all plane-related codes w/ SST #552
base: master
Are you sure you want to change the base?
Conversation
Thanks for this pull request! Could you please prepare a presentation for Monday about these changes? Some observations in no particular order:
|
@olantwin Some thoughts while I was midway of changing the detID: maybe it’s a lot easier and “safer” to leave the plane number 0 as it is. But either way, you’re right that we should have a separate function for construct and destruct. It was a pain in the ass to change them by hand. And I’ll try to fix the commit history. (It was a learning-by-doing situation...) |
Great, I'll put you onto the agenda.
Maybe we can do two steps: move the detID encoding/decoding to a function and then in a second step change the detector ID calculation once, in a single spot while also incrementing the version of the strawtubespoint/hit
No worries, 99% of what I know about git I learnt experimentally by repeatedly getting myself into trouble ;) |
2bfcde6
to
65199fa
Compare
65199fa
to
8cdb210
Compare
Could you please rebase to remove the merge conflicts? They result from deleted files which didn't need updating. |
Just did! |
I think it might have been rebase the wrong way around, the Remove last vestiges of muflux |
6b9bde8
to
766bebe
Compare
@wcmartylee Any updates on this PR? |
I’m sorry... I was busy with other things and couldn’t finish this fix. I was hoping we can complete this quickly on next week’s hackathon. |
Indeed, for this kind of thing the hackathon should work well |
Remove all plane-related codes due to implementation of compact (planeless) strawtubes configuration