Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken doc references #156

Merged
merged 1 commit into from
May 6, 2024

Conversation

patowen
Copy link
Contributor

@patowen patowen commented May 5, 2024

I believe most of these changes are non-controversial, although someone other than me may want to double-check that transfers_submitted and transfers_finished are the right function names to reference, although I don't see what else they could be.

One change I considered making as well was renaming the size parameter in colored_circle to min_radius to match the name of the Circle struct field. When I first used that function, I was a surprised that the size parameter was being ignored, even though it made sense in retrospect. However, I also noticed that many other functions would also need their parameters renamed if I went this route, so this PR only fixes broken references.

Copy link
Collaborator

@kanerogers kanerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks!

@LPGhatguy LPGhatguy merged commit 4782fb3 into SecondHalfGames:main May 6, 2024
2 checks passed
Uriopass pushed a commit to Uriopass/yakui that referenced this pull request Jun 30, 2024
@patowen patowen deleted the documentation-fixes branch July 1, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants