Support rendering to a different subpass in yakui-vulkan #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems good to me! I'll defer to @Ralith or @kanerogers to merge since they're the Vulkan folks. |
kanerogers
approved these changes
May 5, 2024
|
Thanks for the super-quick merging! |
Uriopass
pushed a commit
to Uriopass/yakui
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application has a rendering pass with multiple subpasses, the UI should ideally be able to be rendered on top of the last subpass to avoid being negatively affected by future subpasses. This PR adds that option to
yakui_vulkan::Options.