Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add declare_strict_types to .php_cs #13

Open
SebSept opened this issue Apr 23, 2021 · 0 comments
Open

add declare_strict_types to .php_cs #13

SebSept opened this issue Apr 23, 2021 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@SebSept
Copy link
Owner

SebSept commented Apr 23, 2021

As recommended (and that's a good point :) )
https://devdocs.prestashop.com/1.7/development/coding-standards/#strict-typing

But, adding this requires the cs-fixer:init to have the option to chose for another file...
then the command becomes a bit useless since it's action is just to copy a file.

maybe, the strict type could be include in the original file of prestashop/php-dev-tools.
I should submit an issue.

the pros of using the prestashop/php-dev-tools is that I do not have to maintain the file.

@SebSept SebSept added enhancement New feature or request question Further information is requested labels Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant