Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mongo operators #30

Open
felipenoris opened this issue Sep 4, 2018 · 0 comments
Open

Refactor mongo operators #30

felipenoris opened this issue Sep 4, 2018 · 0 comments

Comments

@felipenoris
Copy link

felipenoris commented Sep 4, 2018

The current design, Mongo.jl overloads some Base functions in order to implement mongo operators.

In my opinion, this is a bad idea. For instance, the definition of in clashes with the definition in Compat, since it is defined for in(::Any).

I would like to propose to use a different namespace for Mongo operators, instead of overloading functions from Base.

Another possibility, preferable in my opinion, is to refactor these definitions to multiple-dispatch to a data-structure that is defined in this package. This way Base functions may be overloaded safely.

WARNING: Method definition in(Any) in module Compat at /Users/felipenoris/.julia/v0.6/Compat/src/Compat.jl:912 overwritten in module Mongo at /Users/felipenoris/.julia/v0.6/Mongo/src/query.jl:21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant