Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfox: repair checkver and autoupdate #14450

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

filip2cz
Copy link
Contributor

They removed G from new versions, so checkver and autoupdate was not working

Closes #14449

They removed G from new versions
Copy link
Contributor

Your changes do not pass checks.

waterfox

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@filip2cz
Copy link
Contributor Author

I believe that checkver is okay, based on output of github action: https://github.com/ScoopInstaller/Extras/actions/runs/11979739107/job/33402545169?pr=14450

@aliesbelik
Copy link
Collaborator

aliesbelik commented Nov 24, 2024

I believe that checkver is okay, based on output of github action: https://github.com/ScoopInstaller/Extras/actions/runs/11979739107/job/33402545169?pr=14450

Guess this means that manifest could be updated to the latest version first.

Github link could be updated to the actual one - https://github.com/BrowserWorks/Waterfox - but this is not critical.

@filip2cz
Copy link
Contributor Author

Guess this means that manifest could be updated to the latest version first.

Sounds like I have to manualy update that manifest :(

@filip2cz
Copy link
Contributor Author

Github link could be updated to the actual one - https://github.com/BrowserWorks/Waterfox - but this is not critical.

looks like this was actually the issue at the end

@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

Your changes do not pass checks.

waterfox

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

waterfox

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@aliesbelik aliesbelik merged commit cb3b93d into ScoopInstaller:master Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Waterfox autoupdate is not working
2 participants