Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probing problems with repo-review checks on tests + docs folders #566

Closed
wants to merge 4 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Nov 18, 2024

Aiming to crudely break both the "has a tests folder" and "has a docs folder" checks for sp-repo-review.
(expected both PY004 and PY005 to fail)
Spoiler : oddly, this doesn't seem to trigger either error as expected
- there is no reported error in the pre-commit.ci run ???

@pp-mo pp-mo closed this Nov 19, 2024
@pp-mo pp-mo reopened this Nov 19, 2024
@pp-mo
Copy link
Member Author

pp-mo commented Nov 19, 2024

Now removed the entire (renamed) docs folder, but the pre-commit.ci still passes, including the repo-review check.
And checking "pp-mo/iris_grib" branch "develop" via their Pyodide-based web interface, likewise also passes + reports "Has a docs folder".
( "develop" branch being same as this, but apparently required as the web-based check only accepts certain branch names )
Total mystery at this point

@pp-mo pp-mo marked this pull request as draft November 19, 2024 13:07
@pp-mo pp-mo closed this Nov 29, 2024
@pp-mo pp-mo deleted the invalidate_paths branch November 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant