Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing CSV file with 2 empty newlines at end fails #7

Open
Vindaar opened this issue Jun 24, 2021 · 1 comment
Open

parsing CSV file with 2 empty newlines at end fails #7

Vindaar opened this issue Jun 24, 2021 · 1 comment

Comments

@Vindaar
Copy link
Member

Vindaar commented Jun 24, 2021

If there's two empty newlines at the end (so one fully empty line), our CSV parser chokes.

It's a bit difficult, as either we need to check for this in the first line counting pass (slows it down) or reduce the size of the final tensor afterwards. Need to think about the most elegant solution.

To reproduce just take a working CSV file and 2 newlines at the end and run.

@Vindaar
Copy link
Member Author

Vindaar commented Dec 2, 2022

This can partially be handled now by using the maxLines option added in #46. Still this particular case should be handled automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant