Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schwarz-theme): use correct theme for dark mode #2320

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Dec 12, 2024

closes #2288

The schwarz-dark theme currently showed the wrong colors (onyx dark mode) because we used :where(.dark) as selector instead of .dark which was a leftover from a previous change.

I've run the Figma update variable workflow to update the theme correctly.

Checklist

  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

This is an auto-generated pull request.
All variables have been updated from the [Figma
file](https://www.figma.com/design/YfEUBOHk4J4nYrk04geswG).

Co-authored-by: larsrickert <[email protected]>
@larsrickert larsrickert requested a review from a team as a code owner December 12, 2024 10:33
Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 731d570

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Patch
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Patch
@sit-onyx/nuxt Patch
@sit-onyx/vitepress-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert enabled auto-merge (squash) December 12, 2024 10:36
@larsrickert larsrickert merged commit b25aa8f into main Dec 12, 2024
19 checks passed
@larsrickert larsrickert deleted the larsrickert/2288-fix-schwarz-theme-dark-mode branch December 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix schwarz theme having onyx colors in dark mode
2 participants