Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OnyxNavButton and OnyxFlyoutMenu disabled state #2238

Open
12 tasks
MajaZarkova opened this issue Dec 4, 2024 · 0 comments
Open
12 tasks

Implement OnyxNavButton and OnyxFlyoutMenu disabled state #2238

MajaZarkova opened this issue Dec 4, 2024 · 0 comments
Assignees
Labels
dev Requires technical expertise

Comments

@MajaZarkova
Copy link
Contributor

MajaZarkova commented Dec 4, 2024

Why?

We need a disabled state for the OnyxNavButton

Design

Figma

Acceptance criteria

  • 'cursor: not-allowed' on hover when it's disabled
  • disabled state meets the style in Figma

Definition of Done

  • The following component requirements are implemented:
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • covered by tests
    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Storybook code snippet of new/changed examples are checked that they are generated correctly
  • Namings are aligned with Figma

Approval

  • Storybook
  • Deployed Docs
  • approved by designer @jannick-ux
  • approved by dev
@MajaZarkova MajaZarkova added this to onyx Dec 4, 2024
@MajaZarkova MajaZarkova converted this from a draft issue Dec 4, 2024
@MajaZarkova MajaZarkova changed the title Implement OnyxNavItem disabled state Implement OnyxNavButton and OnyxFlyoutMenu disabled state Dec 4, 2024
@MajaZarkova MajaZarkova self-assigned this Dec 4, 2024
@MajaZarkova MajaZarkova added the dev Requires technical expertise label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: New
Development

No branches or pull requests

1 participant