Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement: Integrate more list into nav bar #2228

Open
16 tasks
larsrickert opened this issue Dec 4, 2024 · 0 comments
Open
16 tasks

Implement: Integrate more list into nav bar #2228

larsrickert opened this issue Dec 4, 2024 · 0 comments
Labels
0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise

Comments

@larsrickert
Copy link
Collaborator

Why?

We want to integrate the existing OnyxMoreList component in the nav bar so that a "more" nav item is shown if not all nav items fit into the available width so the user can still access all nav items.

Open questions / TODOs

No response

Depends on

Design

Same as OnyxNavButton

Acceptance criteria

  • if not all nav items fit into the available width, remaining items should be grouped in a e.g. " +3more" nav item that shows the remaining nav items
  • if hidden elements contain children, they should still be shown in the more indicator
  • custom nav item content (.e.g badges) are still visible in the more indicator
  • mobileBreakpoint property of the OnyxNavBar is deleted since its no longer needed

Implementation details

No response

Reference implementations

No response

Applicable ARIA Pattern

No response

Definition of Done

  • The following component requirements are implemented:

    • skeleton
    • density
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma

Approval

@larsrickert larsrickert added the dev Requires technical expertise label Dec 4, 2024
@larsrickert larsrickert added this to onyx Dec 4, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Dec 4, 2024
@larsrickert larsrickert added the 0-refinement All issues that can or need to be estimated in our next refinement label Dec 4, 2024
@larsrickert larsrickert moved this from New to Backlog in onyx Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise
Projects
Status: Backlog
Development

No branches or pull requests

1 participant