feat(ci): Add action for bumb version #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Exler <[email protected]> Co-authored-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
|
Tested on fork and works fine 🙂 |
brumhard
suggested changes
Feb 24, 2023
| @@ -0,0 +1,74 @@ | |||
| --- | |||
There was a problem hiding this comment.
Could we somehow reuse the hack/release.sh script here?
There was a problem hiding this comment.
Oh, thanks for the reminder, I forget to take a look into it. I was mostly gone through a tutorial.
Comment on lines
+39
to
+40
| - name: Create release | ||
| run: gh release create {{ steps.tag.outputs.tag }} --verify-tag --generate-notes |
There was a problem hiding this comment.
I don't really understand this change. The workflow should just create the tag and let the release workflow (with goreleaser) take care of creating the release with proper assets.
Comment on lines
+96
to
+99
| svu: ## Creates a new version, args options major, minor & patch | ||
| @go run github.com/caarlos0/svu $(args) --strip-prefix > config/version.txt | ||
| @go run github.com/caarlos0/svu $(args) | ||
|
|
There was a problem hiding this comment.
We already have make release. Why is that needed?
There was a problem hiding this comment.
To bumb version in worklfow based on major, minor & patch. With this is possible to bumb version from the Github Workflow UI.
Signed-off-by: Steffen Exler <[email protected]> Co-authored-by: Steffen Exler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add action for bumb version
Fix #180