Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logic / handle scoping in case_sensitive? #2

Open
ronen opened this issue Apr 20, 2016 · 0 comments
Open

Better logic / handle scoping in case_sensitive? #2

ronen opened this issue Apr 20, 2016 · 0 comments

Comments

@ronen
Copy link
Member

ronen commented Apr 20, 2016

schema_plus_columns' case_sensitive? postgresql implementation returns true if any index that the column is involved in is case sensitive. That isn't always what you want; see the discussion in the commit message of @dmeranda's commit 89f54f to SchemaPlus/schema_validations#39.

Perhaps case_sensitive? should take an optional argument specifying a scope. (If so, mysql should likewise accept a scope argument that it would ignore -- see #1) If a scope were provided, it could be used to obviate the extra logic in @dmeranda's commit 89f54f.

And should the default behavior (no scope specified) change to be something more conservative? That'd be a breaking change of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant