Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics and sleep timer #82

Closed
4 tasks done
Priya-49 opened this issue May 13, 2024 · 8 comments
Closed
4 tasks done

Lyrics and sleep timer #82

Priya-49 opened this issue May 13, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request gssoc level2

Comments

@Priya-49
Copy link

Priya-49 commented May 13, 2024

Describe the feature

Lyrics for the current song being played and sleep timer which allows the user to set a timer to automatically stop playback after a certain period, ideal for falling asleep to music.

Add ScreenShots

Screenshot (209)

Record

  • I agree to follow this project's Code of Conduct
  • I have checked the existing issues
  • I'm a GSSOC'24 contributor
  • I want to work on this issue
Copy link

Congratulations, @Priya-49! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We'd also like to invite you to our Discord server! Join us on discord.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Satyam1923
Copy link
Owner

@Priya-49 if you want to work on these issue please tell the changes you'll be implementing.

@Priya-49
Copy link
Author

I would like to add two buttons one for the lyrics which on clicked displays the lyrics inplace of the image and other for sleep timer for setting the exact time after which the songs pause.

@Satyam1923
Copy link
Owner

Could you please take a look at new designs and tell where we could have lyrics integration.

@saurabhsingh720
Copy link
Contributor

@Priya-49 u can add this fuctionality as soon as possible.

@Priya-49
Copy link
Author

I would like to make the changes in the following way...(lyrics would be displayed on clicking the card)
Screenshot 2024-05-14 115023
Screenshot 2024-05-14 115611

@saurabhsingh720
Copy link
Contributor

@Priya-49 Go for it

@Priya-49
Copy link
Author

Priya-49 commented May 16, 2024

@saurabhsingh720 I have added lyrics feature to the existing design...please have look. And I increased the width since audio player and shuffle button went out of the box in the previous design. I will send the pull request if this is ok.
Screenshot (204)
Unfortunately the lyrics were not available to few song. In this case "Lyrics not found" message would be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

No branches or pull requests

3 participants