Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct SESANS model solid dilute sphere (Trac #728) #844

Closed
sasview-bot opened this issue Mar 30, 2019 · 2 comments
Closed

Direct SESANS model solid dilute sphere (Trac #728) #844

sasview-bot opened this issue Mar 30, 2019 · 2 comments
Assignees
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour SESANS SESANS functionality
Milestone

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

Migrated from http://trac.sasview.org/ticket/728

{
    "status": "closed",
    "changetime": "2016-10-12T08:47:13",
    "_ts": "2016-10-12 08:47:13.344783+00:00",
    "description": "",
    "reporter": "wimbouwman",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SESANS Integration",
    "time": "2016-10-07T18:16:13",
    "component": "SasView",
    "summary": "Direct SESANS model solid dilute sphere",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "wimbouwman",
    "type": "enhancement"
}
@sasview-bot sasview-bot added this to the SasView 4.1.0 milestone Mar 30, 2019
@sasview-bot sasview-bot added Enhancement Feature requests and/or general improvements Incomplete Migration Major Big change in the code or important change in behaviour SESANS SESANS functionality and removed Incomplete Migration labels Mar 30, 2019
@pkienzle
Copy link
Contributor

Trac update at 2016/10/09 17:49:25: pkienzle commented:

This is implemented in sasmodels/models/_spherepy.py as def sesans(z, sld, sld_solvent, radius), and appears in sasmodels as model_info.sesans.

This needs to be made available through sasmodels/sasview_model.py to the calculator(s) in sasview/src/sas/sascalc/fit/BumpsFitting.py or sasview/src/sas/sascalc/fit/AbstractFitting.py, and in sasview/src/sas/sasgui/perspectives/fitting/model_thread.py.

Yet another reason to refactor the modeling interface: the logic to choose the analytic sesans function if it exists, otherwise choose sesans.transform(I(q)) should only be in one place.

@sasview-bot
Copy link
Author

Trac update at 2016/10/12 08:47:13:

  • wimbouwman changed resolution from "" to "fixed"
  • wimbouwman changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour SESANS SESANS functionality
Projects
None yet
Development

No branches or pull requests

3 participants