Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefactor calculation when there are both P(Q) and S(Q) (Trac #1259) #1333

Open
sasview-bot opened this issue Mar 30, 2019 · 5 comments
Open
Assignees
Labels
Enhancement Feature requests and/or general improvements Minor Small job
Milestone

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

The models for vesicle and sphere systems ( P(Q) ) with the hard sphere interaction ( S(Q) ) have two volume fraction: phi_PQ and phi_SQ.
phi_PQ is the volume fraction from the form factor.
phi_SQ is the volume fraction from the structure factor.

Based on the testing of the two models, the prefactor of the scattering intensity is currently set up to be proportional to scale*phi_PQ*phi_SQ.

If the scale is set up to one, the prefactor with the absolute intensity should be proportional to phi_PQ only.
It should not be phi_PQ*phi_SQ.

It is suggested to remove phi_SQ from the calculation of the prefactor.

@sasview-bot
Copy link
Author

Trac update at 2019/03/26 10:16:46: yunliu changed attachment from "" to "TestResults-SphereVesicles-SASView.docx"

@sasview-bot
Copy link
Author

Trac update at 2019/03/26 10:21:09: yunliu changed milestone from "SasView 5.1.0" to "SasView 5.0.0"

@sasview-bot
Copy link
Author

Trac update at 2019/03/26 10:22:38: yunliu commented:

Forgot to mention that the prefactor calculation is the same for both V4.1.2 and V5.0.

@pkienzle
Copy link
Contributor

Trac update at 2019/03/29 20:11:17: pkienzle commented:

I think this is duplicate of SasView/sasview#1280, and is fixed by the following sasmodels PR

https://github.com/SasView/sasmodels/pull/101

Changes between 4 and 5 probably depend on which version of sasmodels is active.

@pkienzle
Copy link
Contributor

This is a GUI problem in SasView 5.0: move to sasview issues

@butlerpd butlerpd transferred this issue from SasView/sasmodels May 12, 2019
@butlerpd butlerpd added this to the SasView 5.0.0 milestone May 12, 2019
@butlerpd butlerpd added Enhancement Feature requests and/or general improvements Minor Small job labels May 12, 2019
@rozyczko rozyczko modified the milestones: SasView 5.0.0, SasView 5.1.0 May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Minor Small job
Projects
None yet
Development

No branches or pull requests

5 participants