Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable encryptors and compressors per protocol #135

Open
JustTalDevelops opened this issue Jun 26, 2022 · 6 comments
Open

Customizable encryptors and compressors per protocol #135

JustTalDevelops opened this issue Jun 26, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@JustTalDevelops
Copy link
Collaborator

In certain cases those settings can be undesired, although they should certainly be on by default.

@JustTalDevelops JustTalDevelops added the enhancement New feature or request label Jun 26, 2022
@JustTalDevelops
Copy link
Collaborator Author

JustTalDevelops commented Jun 27, 2022

It might be better to have the compressors and encryptors configurable themselves, maybe in ListenConfigs or Protocol implementations. Could be useful for custom Protocol implementations.

@JustTalDevelops JustTalDevelops changed the title Toggles for encryption and compression in ListenConfig Customizable encryptors and compressors per protocol Jun 27, 2022
@JustTalDevelops
Copy link
Collaborator Author

It might be better to have the compressors and encryptors configurable themselves, maybe in ListenConfigs or Protocol implementations. Could be useful for custom Protocol implementations.

I think this is the way to go. It doesn't make sense to put it in ListenConfigs, as compression/encryption is really only tweaked with when using Gophertunnel over a different Protocol.

@Sandertv
Copy link
Owner

I wouldn't put this in Protocol either, these are both a different layer than the protocol. Without the correct compression type, you can't find the protocol.

@JustTalDevelops
Copy link
Collaborator Author

Where would you put this then? Listen/Dial configs?

@Sandertv
Copy link
Owner

Probably, honestly.

@Sandertv
Copy link
Owner

Sandertv commented Sep 5, 2022

Coming back to this, with 1.19.30 coming, it would probably make sense to put this in the protocol, as we can now find the protocol before we need to (de)compress or encrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants