Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create script for adding and downloading new repo for labeling. #76

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Create script for adding and downloading new repo for labeling. #76

wants to merge 3 commits into from

Conversation

Yullia
Copy link
Contributor

@Yullia Yullia commented Feb 5, 2024

No description provided.

@Yullia Yullia requested a review from a team as a code owner February 5, 2024 19:11
@Yullia Yullia requested a review from babenek February 5, 2024 19:11
babenek
babenek reviewed Feb 7, 2024
View reviewed changes
dataset_extension/reqiurements_dataset_extension.txt
@@ -0,0 +1,3 @@
detect-secrets
credentialdigger
credsweeper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?
Biting tail? 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have discussed about installation approach for the workflow.
Sometime it should be done with a custom version of credsweeper.
And other scanners require a bit complex installation process.
IMO the scanners must be not mentioned in requirements.txt.
I mean the image may display how it looks for me: the pupi pulls byself with their tail :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right. I agree.

babenek
babenek requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide github action with the scan of CredSweeper repo and adding the found items into meta?
The meta does not need to be updated - just add an artifact for github job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csh519 csh519 csh519 left review comments

@babenek babenek babenek requested changes

@xDizzix xDizzix xDizzix approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yullia @xDizzix @babenek @csh519