Linking #19
Open
Linking #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a very crude account linking method that allows the user to link a steam account to 1 discord account (discord accounts can only have 1 linked account but steam accounts can have multiple connected discord accounts). Also created a text file to store linked accounts
Didn't think leaving my bot token would be a good idea :P
dtracers
requested changes
May 9, 2019
| @@ -0,0 +1 @@ | |||
| 298910672731766784:76561198404047726 | |||
There was a problem hiding this comment.
This does not need to be committed.
But I like the format of it
| @@ -274,9 +276,49 @@ def chunks(l, n): | |||
| args = ctx.message.content.split(" ") | |||
|
|
|||
| if len(args) < 2: | |||
| await bot.send_message(ctx.message.channel, | |||
| PastUsers = open("UserIDs.txt", "r+") | |||
| NotLinked = True | |||
There was a problem hiding this comment.
We should load this at bot startup instead of at every call
| except ImportError: | ||
| print('Unable to run bot, as token does not exist!') | ||
| sys.exit() | ||
|
|
||
| bot = Bot(BOT_PREFIX) | ||
| bot.remove_command("help") | ||
|
|
||
| NotLinked = True |
There was a problem hiding this comment.
load it into a map at bot startup and then not have a global variable
Sciguymjm
requested changes
May 9, 2019
| @@ -13,14 +13,16 @@ | |||
| from discord.ext.commands import Bot | |||
|
|
|||
| try: | |||
| from config import TOKEN, BOT_PREFIX | |||
| from config_example import TOKEN, BOT_PREFIX | |||
| async def test(ctx): | ||
| #Gets id that is being linked to | ||
| args = ctx.message.content.split(" ") | ||
| UserID = args[1] |
There was a problem hiding this comment.
Snake case for all variables please.
| for line in PastUsers: | ||
| check = line | ||
| check = check.strip() | ||
| check = check.split(":") |
There was a problem hiding this comment.
Same thing as the other comment. Possibly put this code in a function so you don't have to write it twice.
Co-Authored-By: Matthew Mage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no clue how to use github, but I think this works :P . Seriously though, how do I use this.