Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Shots to on target and off target #201

Open
dtracers opened this issue Oct 20, 2019 · 4 comments
Open

Expand Shots to on target and off target #201

dtracers opened this issue Oct 20, 2019 · 4 comments

Comments

@dtracers
Copy link
Member

Currently we only detect on target shots.

We should expend to off target shots.

This will use ball prediction but will detect if a ball travels really close to the goal but would not go in.

@DivvyCr
Copy link
Contributor

DivvyCr commented Jul 1, 2020

Just a thought for whoever might decide to do this: Couldn't this be done post-factum? i.e. if shot not scored, and no saves awarded, then it's off target?

@dtracers
Copy link
Member Author

dtracers commented Jul 1, 2020

what is "shot"?

Currently a psyonix shot includes off target.
But how we detect a "shot" is that it goes into the goal using ball physics predictino from the moment it is hit.

@sertalpbilal
Copy link

Are there any plans on this work? I was wondering how difficult it is to find frames where a "shot" is awarded (by Psyonix) and find the last time user hits the ball. I could have a look at this if there is a way to find all the hits by a player. I see this data in the output JSON file, but cannot find the piece that generates it.

@naston
Copy link

naston commented Jan 18, 2022

wanted to ask if anyone has any leads on this issue? is there any way to find the frame at which a shot is awarded or do we only receive frame markers for tick marks? if anyone has any thoughts please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants