Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard tokens are missing in the build #316

Open
1 of 2 tasks
TiddoLangerak opened this issue May 23, 2023 · 1 comment
Open
1 of 2 tasks

dashboard tokens are missing in the build #316

TiddoLangerak opened this issue May 23, 2023 · 1 comment

Comments

@TiddoLangerak
Copy link

TiddoLangerak commented May 23, 2023

  • bug report
  • feature request

Subject of the issue

The dashboard tokens aren't present in the build (linking to unpkg here. You can also find it on npm -> code -> /js/dashboard/lightMode/common.js (same with darkmode version, and any other target platforms)).

Expected Behaviour

The dashboard tokens should be present in the build.

Current Behaviour

The dashboard tokens are not present in the build.

Possible Solution

Not really a solution, but rather a bit of debugging I've done:

While the tokens are present in the source data set, they already disappear during the prebuild step. The generated tmp/tokens.json file still has the sections and structure for dashboard/lightMode and dashboard/darkMode, but all the values are missing.

I noticed that in the source, the dashboard sections reference variables from origin. It looks like these aren't resolved properly during the build, and silently go missing.

Steps to Reproduce

Option 1: inspect the existing published packages.

E.g. on npmjs.org in the code tab you can see that the variables for dashboard/lightMode and dashboard/darkMode are missing (for every target: css, js, android, etc.).

Option 2: build from scratch

  1. Run the build script npm run build
  2. Observe that none of the dashboard variables are present in the files in the dist folder.

Your environment

@pavel-shermayster-sage
Copy link

pavel-shermayster-sage commented Jun 20, 2024

Can't find this value as well.

"value": "#0D7E7D",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants