Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-701] run JSON to Parquet workflow every sunday at 2am #156

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[ETL-701] run JSON to Parquet workflow every sunday at 2am #156

merged 4 commits into from
Dec 13, 2024

Conversation

philerooski
Copy link
Contributor

No description provided.

@philerooski philerooski requested a review from a team as a code owner December 11, 2024 22:34
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

thomasyu888
thomasyu888 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@philerooski
Copy link
Contributor Author

I filed a ticket here for the broken action: https://sagebionetworks.jira.com/browse/ETL-702

I will manually carry out the rest of the CI steps on Friday once I'm back.

rxu17
rxu17 reviewed Dec 12, 2024
View reviewed changes
.github/workflows/upload-and-deploy.yaml Outdated
@@ -240,6 +240,7 @@ jobs:
password: ${{ needs.pytest-docker.outputs.ecr-password }}
env:
DISABLE_SSL: true
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove these modifications, I don't think these will work anymore

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@philerooski
Copy link
Contributor Author

Tests pass and branch can be successfully deployed with the new schedule.

@philerooski philerooski merged commit 6a9e4ae into main Dec 13, 2024
17 of 19 checks passed
@philerooski philerooski deleted the etl-701 branch December 13, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu17 rxu17 rxu17 left review comments

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philerooski @thomasyu888 @rxu17