Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When extension is on, streams never emits "end" #62

Open
piotrkochan opened this issue Feb 18, 2020 · 4 comments
Open

When extension is on, streams never emits "end" #62

piotrkochan opened this issue Feb 18, 2020 · 4 comments

Comments

@piotrkochan
Copy link

const stream = myService.RunCommand(request, {});
stream.on('end', () => {
  console.log('this is never fired');
});
@rogchap
Copy link
Contributor

rogchap commented Feb 20, 2020

Thanks for reporting @piotrkochan; the end event is a new addition that has not been included yet. Should be straight forward to add.

@piotrkochan
Copy link
Author

@rogchap is it fixed?

@piotrkochan
Copy link
Author

@rogchap it looks like it does not work yet

@rogchap
Copy link
Contributor

rogchap commented Aug 1, 2020

Sorry, have been too busy with another project. Are you able to create a PR for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants