Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove share from local oc_share if OCM invites errored #92

Closed
michielbdejong opened this issue Feb 8, 2023 · 4 comments
Closed

Remove share from local oc_share if OCM invites errored #92

michielbdejong opened this issue Feb 8, 2023 · 4 comments

Comments

@michielbdejong
Copy link
Contributor

The MixedGroupShareProvider first adds an entry into oc_share and then sends OCM invites.
When this fails, the local share should be removed from the oc_share table.

@thepeak99
Copy link
Contributor

Related to #31.

Needs more discussion

@soltanireza65
Copy link
Collaborator

@michielbdejong
can you pls just write down the scenario so that I can follow it through the code?
I do not know how MixedGroupShareProvider relates to the issue,
because sharing a file with a remote group is in the files_sharing app which we have replaced the controllers in ocm app

@soltanireza65
Copy link
Collaborator

so the flow starts with files_sharing/lib/Share20OcsController:createShare

@soltanireza65
Copy link
Collaborator

soltanireza65 commented Jul 11, 2023

I just found the flow
it was our (OCM app) AbstractFederatedShareProvider::createFederatedShare that handles this
and if the result happens to be a failure it calls removeShareFromTableById to remove the created share from local oc_share

this is the scenario that I have tested:
stopped the oc2.docker service
and try to share a file with [email protected]
so because remote servers were not available, then the $result happens to be false,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants