Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer event forwarding #850

Open
dlyr opened this issue Jan 13, 2022 · 2 comments
Open

Viewer event forwarding #850

dlyr opened this issue Jan 13, 2022 · 2 comments
Labels
enhancement Type of issue/PR: enhancement question Type of issue/PR: question asked refactor Related to refactoring actions

Comments

@dlyr
Copy link
Contributor

dlyr commented Jan 13, 2022

Viewer to plugin key and mouse event were requested in #677 and solved in #848
We may have dual behavior for event propagation, either with emitted signals or with callback registration.
Are both behavior needed ? if not which one should we keep ?

Currently, key event need to be registered with callback, and mouse event use qt signals.

@dlyr dlyr added enhancement Type of issue/PR: enhancement question Type of issue/PR: question asked refactor Related to refactoring actions labels Jan 13, 2022
@MathiasPaulin
Copy link
Contributor

I do not understand why to restrict the question to viewer/plugins communication. I think that all events not managed by viewer should be transmitted to any registrated listener (application, plugin, object, …). Perhaps il is just a matter of wording but I think the precision is important.

@dlyr dlyr changed the title Viewer to plugin events Viewer event forwarding Jan 14, 2022
@dlyr
Copy link
Contributor Author

dlyr commented Jan 18, 2022

duplicate of #792 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type of issue/PR: enhancement question Type of issue/PR: question asked refactor Related to refactoring actions
Projects
None yet
Development

No branches or pull requests

2 participants