Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle empty skeletons with assimp #755

Open
nmellado opened this issue May 6, 2021 · 1 comment
Open

Better handle empty skeletons with assimp #755

nmellado opened this issue May 6, 2021 · 1 comment
Labels
enhancement Type of issue/PR: enhancement IO Related to Ra::IO

Comments

@nmellado
Copy link
Contributor

nmellado commented May 6, 2021

The fix introduced in #754 seems "correct", but we way need to refactor animation loading a bit.
I'm not an expert in assimp functionalities, maybe check some tutorial like http://ogldev.org/www/tutorial38/tutorial38.html

Originally posted by @dlyr in #754 (comment)

@nmellado nmellado added enhancement Type of issue/PR: enhancement IO Related to Ra::IO labels May 6, 2021
@MathiasPaulin
Copy link
Contributor

The management of the skeleton loading in Radium correspond to what is described in the official assimp documentation http://assimp.sourceforge.net/lib_html/data.html.

Note that as assimp do not have the notion of skeleton (but only the notion of bones), and that inferring, in a general way, a skeleton from the node hierarchy is quite heuristic. In order to not miss needed nodes for the skeleton, the heuristic used in Radium is very conservative. That's why the old version defined empty skeleton that should be removed at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type of issue/PR: enhancement IO Related to Ra::IO
Projects
None yet
Development

No branches or pull requests

2 participants