Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUBGRF_SetRfTxPower interprets power argument incorrectly. #64

Open
Miceuz opened this issue Mar 24, 2023 · 3 comments
Open

SUBGRF_SetRfTxPower interprets power argument incorrectly. #64

Miceuz opened this issue Mar 24, 2023 · 3 comments
Assignees
@RJMSTM
Labels
bug Something isn't working internal bug tracker Issue confirmed and logged into the internal bug tracking system mw Middleware-related issue or pull-request. subghz Sub-GHz radio

Comments

@Miceuz
Copy link

Miceuz commented Mar 24, 2023

The bug is in Middlewares/Third_Party/SubGHz_Phy/stm32_radio_driver/radio_driver.h:

SUBGRF_SetRfTxPower expects Tx power level [0..15]. It does checks on power > 15 to select RFO_HP and then it calls SUBGRF_SetTxParams that expects RF output power [-18..13] dBm.

So it interprets power argument incorrectly as it it's index, not dBm while later it's used as dBm. All the client code in https://github.com/stm32duino/STM32LoRaWAN/ uses SUBGRF_SetRfTxPower providing power in dBm.
@RJMSTM RJMSTM added the mw Middleware-related issue or pull-request. label Mar 28, 2023
@RJMSTM
Copy link
Contributor

RJMSTM commented Mar 28, 2023

Hi @Miceuz,

Thank you for this report. We will get back to you as soon as we analyze it further. This may take some time. Thank you for your comprehension.

With regards,
Rania

@fpistm fpistm mentioned this issue Apr 11, 2023
Merged
@fpistm
Copy link

fpistm commented Apr 11, 2023

Hi @Miceuz
and thanks to submit this issue.
@RJMSTM is there an internal BZ about this? Thanks.

@ASELSTM
Copy link
Contributor

ASELSTM commented Apr 13, 2023

ST Internal Reference: 149717

@ASELSTM ASELSTM added internal bug tracker Issue confirmed and logged into the internal bug tracking system subghz Sub-GHz radio labels Apr 13, 2023
@ALABSTM ALABSTM added the bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RJMSTM RJMSTM

Labels
bug Something isn't working internal bug tracker Issue confirmed and logged into the internal bug tracking system mw Middleware-related issue or pull-request. subghz Sub-GHz radio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Miceuz @fpistm @ALABSTM @ASELSTM @RJMSTM