Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Milestone 1 feedback #16

Open
yuliaUU opened this issue Mar 5, 2020 · 0 comments
Open

Milestone 1 feedback #16

yuliaUU opened this issue Mar 5, 2020 · 0 comments

Comments

@yuliaUU
Copy link

yuliaUU commented Mar 5, 2020

Overall: great job!! and your choice of the dataset is very interesting!

Task 2.1:

  • overall your report structure is tiny bit confusing, you basically start with loading your data - but according to the assignment it was only task 2.2. So not very sure where task 2.1 ends ( I assume up to EDA)
  • In your data description, you forgot to explain what each column means. Columns names are not self-explanatory and some commentary is greatly appreciated!
  • Line features <- CAN %>% colnames() %>% as_tibble() gave you a warning, that basically telling you that your way of obtaining what you want is not encouraged. It would be better to do something different ( see an example of how the similar table was made in the example provided)

Task2.2:

  • awesome! dataset is read and included in the repo!

Task2.3:

  • I would suggest before you provide a 1st plot, you first state what question you want to answer with this analysis or what you were exploring. you did exactly what is needed when you continue: e.g. "We explore how many videos are in each category"... so now I know what you were going after and it is easy to follow:)
  • Minor issue: your 1st graph and text below were not separated by an empty line, that is why text begins in the middle of the picture. Make sure you inspect your knitted document better to catch such minor mistakes!
  • The category corresponding to its ID section should have been put when you introduce your dataset (I was spending quite a time looking at your table and a graph wondering what does category number means before I saw your explanation)
    -"Here we compute the mean views, likes, dislikes and comment counts for video category." you provide a table but do not provide any summary of what that table showed you or how to interpret the data
  • The last graph in EDA section has too much white space due to one point being way off in the right corner. I wonder whether logging the data would help to make a picture better?
  • Not sure what line ## Selecting by comment_count means
    Task2.4: sounds exciting! I am curious about what kind of result you will obtain.

Other issues you need to address:

  • group_2.Rproj should not be in the repo, it is your private document that you do not share ( so when you do commit from R studio, make sure you don't include the Rproj changes)
  • Readme file needs to be more descriptive; ie what can I find in the data folder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant