Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SRGProduct alias, keep product name string #53

Open
pyby opened this issue Nov 22, 2023 · 0 comments
Open

Remove SRGProduct alias, keep product name string #53

pyby opened this issue Nov 22, 2023 · 0 comments
Labels
enhancement

Comments

@pyby
Copy link
Member

pyby commented Nov 22, 2023 •
edited
Loading

Issue type

Feature request

Description of the problem

From PR review #52, the SRGProduct and product name string duplication looks not necessary anymore (discussion).

Removing SRGProduct and keeping only the product name string should let the flexibility of new PAC product and remove the similar methods "for" product: and "for" productName:.

Environment information

  • Library version: 18.0.0
  • iOS / tvOS version: Any
  • Device: Any
@pyby pyby mentioned this issue Nov 22, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pyby