-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AVMetrics
#925
Comments
Gave a shot at the implementation for fun on
|
The single subscriber issue is not related to the This issue also affects different streams matching different event types. Only one stream will deliver events, at random if For this reason I think that:
|
To avoid issues with marking APIs as available on iOS / tvOS 18+ I would suggest the following:
Since |
Current state as of beta 5:
|
Timings from content key metric events still zero on iOS 18 beta 6 😭 |
Still missing with iOS 18 beta 7. |
Radar Missing timing metrics in |
Still missing with iOS 18 beta 8. |
I received feedback for FB14875223. This is expected behavior according to Apple, after all there is no The recommended approach to obtain metrics is to access the
|
As a Pillarbox developer I want to benefit from new APIs introduced in iOS and tvOS 18 to better understand the behavior of Pillarbox.
Remarks
timeSpentInInitialStartup
provided inAVMetricPlayerItemPlaybackSummaryEvent
matchestimeTaken
fromAVMetricPlayerItemInitialLikelyToKeepUpEvent
. These values are smaller than the values we get when measuring the total startup time according to recommendations provided at WWDC. It is also the same value as provided by the first eventstartupTime
in the access log.Hints
AVMetrics
are missing in iOS 18 beta 1.AVMetricContentKeyRequestEvent
provides the key system used to load the content. It can be compared toclearKey
,authorizationToken
orfairPlayStreaming
to find its type, letting us guess which timing we need to provide. Note that our token-protected streams are currently reported as usingclearKey
.Acceptance criteria
AVPlayer
metrics are provided in Pillarbox player metric events.Tasks
AVMetrics
events.Check consistency between APIs (e.g. stalls or fatal / non-fatal errors).AVMetricEvent
to be collected even if not needed, though). Or we could just collect some essential events and discard less relevant ones, at least for tracker implementation purposes.The text was updated successfully, but these errors were encountered: